[2.1] fixed tons of missing/wrong use statements #3496
Conversation
…ie in Zend\Http\Client\Cookies
… Zend\Session\Storage\SessionArrayStorage
…t\Controller\AbstractControllerTestCase
…t\ServerIntrospection
| @@ -180,7 +181,7 @@ public function getRequest() | |||
|
|
|||
| /** | |||
| * Get the application response object | |||
| * @return \Zend\Stdlib\ResponseInterface | |||
| * @return ResponseInterface | |||
There was a problem hiding this comment.
I think we do not add a use just for something that is in a comment (at least someone told me not to do one day).
There was a problem hiding this comment.
@bakura10 We often do this to make the comments more readable and coherent.
Since phpdoc and most ides resolve them based on the imports/namespace,
they continue to document correctly. Since PHP does not expand an import or
try to autoload it unless the code actually references it, it's a no-op for
the engine.
On Saturday, January 19, 2013, Michaël Gallego wrote:
In library/Zend/Test/PHPUnit/Controller/AbstractControllerTestCase.php:
@@ -180,7 +181,7 @@ public function getRequest()
/** * Get the application response object
\* @return \Zend\Stdlib\ResponseInterface\* @return ResponseInterfaceI think we do not add a use just for something that is in a comment (at
least someone told me not to do one day).—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3496/files#r2706310.
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
There was a problem hiding this comment.
Doing this we miss the possibility of scan use statements for detect direct dependencies
There was a problem hiding this comment.
Additionally ResponseInterface is used here : https://github.com/marc-mabe/zf2/blob/c7b97774ce68ea0472accbd393ff5f938ebb2c57/library/Zend/Test/PHPUnit/Controller/AbstractControllerTestCase.php#L294
ghost
assigned 
|
@weierophinney @Maks3w What about the unresolved errors I wrote about in PR description? |
|
@marc-mabe Can you open different issues for that? |
On the following errors I need help to resolve
Zend\Db\Metadata\Source\AbstractSourceuses the not existing classObject\ConstraintKeyObjectZend\XmlRpc\Server\Exception\Stdin::____construct()usesnew ServerExceptionwhich is defined asuse Zend\XmlRpc\Server\Exception as ServerExceptionZend\XmlRpc\AbstractValue::_phpVarToNativeXmlRpcchecks against the not existing classZend\Math\BigInteger